Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unix, wasm: call exit(2) instead of abort or unreachable #4245

Closed
wants to merge 1 commit into from
Closed

unix, wasm: call exit(2) instead of abort or unreachable #4245

wants to merge 1 commit into from

Commits on Apr 28, 2024

  1. unix, wasm: call exit(2) instead of abort or unreachable 

    This matches upstream Go, and I think it's a better idea in general.

Specifically, it avoids triggering an 'undefined' instruction in wasm
when there's a panic. Many people confuse this 'undefined' instruction
(with associated backtrace) with the actual bug.

A possible downside is that this unreachable instruction does show a
backtrace, which may be helpful in finding the underlying bug. Calling
exit(2) doesn't have this behavior.
    @aykevl
    aykevl committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    b71d9f5 View commit details
    Browse the repository at this point in the history