Support UF2 drives with space in their name on Linux #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some devices, such as Seeed Studio XIAO with Adafruit bootloader, use complex names for UF2 device. With this fix applied, /proc/mounts should be parsed correctly
|
Could you please provide the bootloader you've tried? |
|
I've tried both 3.16 (the version you've linked), and the 3.14 (https://github.com/adafruit/uf2-samdx1/releases/tag/v3.14.0). Both versions use "Seeed XIAO" as the device name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the factory bootloader on one of my Seeed Studio XIAOs to the latest version provided by Adafruit. Their bootloader uses different name for UF2 device, "Seeed XIAO", instead of "Arduino".
Unfortunately, after the update
tinygo flashwas no longer able to detect the device, even if the board configuration was correct. It looks like the entry in/proc/mountsfile uses\040instead of afindFATMountsfunction can't handle such a case:This PR fixes the issue on Linux. I've tested it on my PC (Debian 12) against dev branch, with both original bootloader and the updated one.