os/Chown

[leongross]

Add os.Chown()

[leongross]

To design meaningful test cases for chown, I think you would need multiple users with different uids and gids and a user who has permission to change ownership of a file to this, a super user. In my opinion, there are 2 ways to integrate this:

1. update the container image for the CI so that there are accounts with said properties
2. mocking the file system and permissions

The problem I see with solution 2 is that the implementation of chown relies on the syscall chown, so I wouldn't know how to mock that.

I would appreciate your input on that @rminnich

EDIT: Maybe I am mistaken but as I see it, golang does not do any of the described tests but checks for an error of an invalid gid, maybe this is the way to go here as well?

[leongross]

@deadprogram do you have an opinion on that?

[leongross]

@deadprogram

[leongross]

@rminnich

[aykevl]

I think it's fine to keep this lightly tested, for example by checking that the syscall returns an expected permission error (or even just "file not found" - it also means the call works at least somewhat).

Yes it would be great to be able to test everything, but that's very hard to do for things like this and you'll end up putting a lot of effort into what's essentially just a wrapper for a libc function.