add waveshare pico variants #4129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why test-all failed. |
It's a flaky test that we need to investigate. I've restarted the build. |
aykevl
reviewed
Feb 25, 2024
|
Looks like another flaky test caused this to fail? I implemented your requested changes. Bummed this didnt make the cut for 0.31.0 |
|
Hello @crypto-smoke thanks for the PR and likewise sorry it did not get in the last release. Furthermore, now that #4215 has been merged into Would it be too much trouble to ask for you to rebase against the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds board and target files for Waveshare 2040 LoRa and Plus boards.