-
Notifications
You must be signed in to change notification settings - Fork 851
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
lint: add "make lint" target, run it from ci
See #4225 Runs in both circleci and github, circleci is run on branch push, github is run on PR Revive builds so fast, don't bother installing it; saves us wondering which one we get Uses tools.go idiom to give control over linter versions to go.mod. Also pacifies linter re AppendToGlobal as a token first fix. TODO: gradually expand the number of directories that are linted, uncomment more entries in revive.toml, and fix or suppress the warnings lint finds. TODO: add linters "go vet" and staticcheck NOT TODO: don't add metalinters like golangci-lint that pull in lots of new of dependencies; we'd rather not clutter go.mod that much, let alone open ourselves up to the additional attack surface.
- Loading branch information
1 parent
90b0bf6
commit 3181bf9
Showing
8 changed files
with
103 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| // Install linter versions specified in go.mod | ||
| // See https://marcofranssen.nl/manage-go-tools-via-go-modules for idom | ||
| package tools | ||
|
|
||
| import ( | ||
| _ "github.com/mgechev/revive" | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| ignoreGeneratedHeader = false | ||
| severity = "warning" | ||
| confidence = 0.8 | ||
| errorCode = 0 | ||
| warningCode = 0 | ||
|
|
||
| # Enable these as we fix them | ||
| [rule.blank-imports] | ||
| [rule.context-as-argument] | ||
| [rule.context-keys-type] | ||
| [rule.dot-imports] | ||
| [rule.error-return] | ||
| [rule.error-strings] | ||
| [rule.error-naming] | ||
| [rule.exported] | ||
| [rule.increment-decrement] | ||
| [rule.var-naming] | ||
| [rule.var-declaration] | ||
| #[rule.package-comments] | ||
| [rule.range] | ||
| [rule.receiver-naming] | ||
| [rule.time-naming] | ||
| [rule.unexported-return] | ||
| #[rule.indent-error-flow] | ||
| [rule.errorf] | ||
| #[rule.empty-block] | ||
| [rule.superfluous-else] | ||
| #[rule.unused-parameter] | ||
| [rule.unreachable-code] | ||
| #[rule.redefines-builtin-id] |