hci: implement set random MAC address #229
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit hesitant with this PR because it's a bit more complicated than that: there are three different kinds of random MAC addresses. See this post for details: https://novelbits.io/bluetooth-address-privacy-ble/. This PR doesn't distinguish between the three, which means the API will need to change in the future. I plan on implementing private addresses in the bluetooth package eventually, after implementing pairing and bonding. |
Signed-off-by: Xudong Zheng <7pkvm5aw@slicealias.com>
Signed-off-by: Xudong Zheng <7pkvm5aw@slicealias.com>
xudongzheng
force-pushed
the
hci-rand-addr-pr
branch
from
8dc46b3
to
393949d
Compare
xudongzheng
changed the title
|
That sounds reasonable. I'll mark the PR as a draft for now until there is a bit more clarity around how MAC addresses should be stored internally. I'll keep this semi-updated as it's useful for #230. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.