Move install-related dev scripts to device/ folder #1793
Conversation
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
⏳ Approval Pending (2 unresolved comments)
Approval will be granted automatically when all comments are resolved
In: Discussion
Initially I thought we should also move the enable-passwordless-sudo script there as well
Apart from using in it CI, as you mentioned, we also only reference it in the CONTRIBUTING doc. I would also say it should stay put.
In: Discussion
I also think dev-scripts/debug-logs should be moved to the device/subdirectory, but it looks like it only exists for backwards compatibility. So I would probably not touch it at this point.
In: CONTRIBUTING.md:
> Line 166
1. Run the [`dev-scripts/device/install-from-source`](dev-scripts/install-from-source) script to build and install your branch's code. For example:
Missed one: dev-scripts/install-from-source -> dev-scripts/device/install-from-source
👀 @jotaen4tinypilot it's your turn please take a look
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
In: Discussion
It’s my understanding as well that we cannot move it right now, unfortunately. I’m actually wondering whether we are able to delete that script by now.
In: CONTRIBUTING.md:
Oh, thanks, fixed.
There was a problem hiding this comment.
Automated comment from CodeApprove ➜
Approved: I have approved this change on CodeApprove and all of my comments have been resolved.
Related #1716. Stacked on #1791.
This PR moves both install-related dev scripts to a new subfolder
device/. This is mostly for clarity, to communicate that these two scripts are not supposed to be executed on a dev machine.Initially I thought we should also move the
enable-passwordless-sudoscript there as well, but I’m not so sure about that anymore, because I think it also would be possible to run it in a dev environment. E.g., we also run it on CI for the e2e tests.