New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressed couple of feedbacks from the list mentioned in #34 #48

Merged

detiber merged 1 commit into tinkerbell:main from parauliya:address-feedback

Mar 10, 2021

Contributor

parauliya commented Mar 10, 2021

Signed-off-by: parauliya aman@infracloud.io

Description

Modified the error statements as mentioned in one of the comments in Address feedback from https://github.com/tinkerbell/cluster-api-provider-tink/pull/8 #34
Update the package name of workflow controller as mentioned in one of the comments in Address feedback from https://github.com/tinkerbell/cluster-api-provider-tink/pull/8 #34

Why is this needed

Fixes: #34

How are existing users impacted? What migration steps/scripts do we need?

No Impact.

Checklist:

I have:

updated the documentation and/or roadmap (if required)
added unit or e2e tests
provided instructions on how to upgrade


          Addressed couple of feedbacks from the list mentioned in tinkerbell#34

db99a28

Signed-off-by: parauliya <aman@infracloud.io>

invidian approved these changes

View reviewed changes

detiber merged commit a32255d into tinkerbell:main

invidian mentioned this pull request

Address feedback from https://github.com/tinkerbell/cluster-api-provider-tink/pull/8 #34

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment