Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback from https://github.com/tinkerbell/cluster-api-provider-tink/pull/8 #34

Open
detiber opened this issue Feb 16, 2021 · 4 comments · Fixed by #48
Open

Address feedback from https://github.com/tinkerbell/cluster-api-provider-tink/pull/8 #34

detiber opened this issue Feb 16, 2021 · 4 comments · Fixed by #48
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v0.5

Comments

@detiber
Copy link
Contributor

detiber commented Feb 16, 2021

#32 was created to merge the current state of PoC work from #17, which also included changes from #8.

Feedback from #8 still needs to be reviewed and addressed.
@detiber detiber mentioned this issue Feb 16, 2021
Closed
@invidian
Copy link
Contributor

/area tech-debt 😄

@gauravgahlot gauravgahlot mentioned this issue Mar 5, 2021
Merged
@detiber
Copy link
Contributor Author

detiber commented Mar 8, 2021

Tried to gather links to the unaddressed feedback here, in some cases the files have moved (in particular the removal of internal directories).

parauliya added a commit to parauliya/cluster-api-provider-tink that referenced this issue Mar 10, 2021
@parauliya
Addressed couple of feedbacks from the list mentioned in tinkerbell#34
db99a28 
Signed-off-by: parauliya <aman@infracloud.io>
@parauliya parauliya mentioned this issue Mar 10, 2021
Merged
3 tasks
detiber added a commit that referenced this issue Mar 10, 2021
@detiber
Merge pull request #48 from parauliya/address-feedback
a32255d 
Addressed couple of feedbacks from the list mentioned in #34
@invidian
Copy link
Contributor

#48 did not address all points here.

@invidian invidian reopened this Mar 10, 2021
@gauravgahlot gauravgahlot mentioned this issue Mar 23, 2021
Closed
3 tasks
@tstromberg tstromberg added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 27, 2021
@chrisdoherty4 chrisdoherty4 added this to the v0.3 milestone Aug 4, 2022
@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Aug 4, 2022 •
edited

This needs triaging and breaking into separate issues as needed with the intention of closing this given how old it is and reasonably significant changes to the code base.

@displague displague mentioned this issue Aug 29, 2022
Closed
@chrisdoherty4 chrisdoherty4 modified the milestones: v0.3, v0.4 Aug 29, 2022
@chrisdoherty4 chrisdoherty4 modified the milestones: v0.4, v0.5 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v0.5
Development

Successfully merging a pull request may close this issue.

Addressed couple of feedbacks from the list mentioned in #34 parauliya/cluster-api-provider-tink
4 participants
@tstromberg @detiber @chrisdoherty4 @invidian