Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ContentType to headers sent to AWS S3 #4395

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arzafran
Copy link

ContentType header was missing in next-tinacms-s3 package, making AWS serve SVGs as application/octet-stream.

This PR solves it by pulling the mimetype from the file and if it's not available it fallbacks to application/octet-stream

@arzafran arzafran requested a review from a team as a code owner December 11, 2023 16:37
Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: 00f7853

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
next-tinacms-s3 Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


arzafran seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants