Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to dismiss a toast #90

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

FaisalST32
Copy link

@FaisalST32 FaisalST32 commented Jun 19, 2021

As part of this PR, I have added a simple x button to dismiss the toast based on the option canDismiss specified while creating the toast #7 .

Would love it if this can be reviewed.

image

…t interface and in turn to ToastOptions interface
@vercel
Copy link

vercel bot commented Jun 19, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/timo/react-hot-toast/Dh5TosuPqSkGLHm48ZL9i4wg1zN5
✅ Preview: https://react-hot-toast-git-fork-faisalst32-feature-dismiss-toast-timo1.vercel.app

@marksark
Copy link

is this going to me merged soon? Would be really helpful to my team and I using hlReact in angularJS. Instead of enabling jsx in our compiler this PR would allow us to have a built in dismiss button

@Simba14
Copy link

Simba14 commented Jul 4, 2022

Hello, What's the status of this? Really would benefit from having this functionality! 💫

@Absleepy
Copy link

Any updates on this issue?

@Im-Fran
Copy link

Im-Fran commented Sep 23, 2022

Hi, any updates on this? it's been over a year now since it was opened and last updated...

@vercel
Copy link

vercel bot commented Nov 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
react-hot-toast ✅ Ready (Inspect) Visit Preview Nov 11, 2022 at 4:18AM (UTC)

@FaisalST32
Copy link
Author

nudge

@iashris
Copy link

iashris commented Feb 12, 2023

Can we please merge this?

@adamita
Copy link

adamita commented Mar 1, 2023

would be a great feature, please merge this 👍

@Darren120
Copy link

HELLO!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants