Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Chrome touch & preventDefault #341

Closed
wants to merge 1 commit into from
Closed

Conversation

inuyaksa
Copy link

fix double events pointer/touch on Chrome >=55 #303
Unable to preventDefault inside passive event listener due to target being treated as passive. #328

PR Checklist

Please review the guidelines for contributing to this repository.

  • I am requesting to pull a topic/feature/bugfix branch (right side). In other words, not master.
  • I have run grunt against my changes and both linting and tests pass.
  • I have added tests to prove my fix is affective or my feature works. This can be done in the form of unit tests in test/bdd/test.js or a new demo on demo/index.html.
  • I have added or edited necessary documentation in the README.md (if appropriate).

Description

Fixes: #

fix double events pointer/touch on Chrome >=55 timmywil#303
Unable to preventDefault inside passive event listener due to target being treated as passive. timmywil#328
@jcnventura
Copy link
Contributor

Hi @inuyaksa

Thanks for submitting a pull request.. Note that this broke a lot of tests, and I'm not sure which of the changes is the one responsible.

Can I ask you two things:

  1. Create two pull requests. Each one should handle either Pinch zoom broken in Chrome v55.02883.91 on Mobile #303 or Unable to preventDefault inside passive event listener due to target being treated as passive.  #328.
  2. Make sure that the tests pass, or fix the tests, justifying why the current tests are wrong.

Thanks!

@timmywil timmywil closed this Jul 24, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants