Backport to 2.14.x: #6726: Fix constify cagg_watermark using window functions #6728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When querying a realtime Continuous Aggregate using window functions the new planner optimization to constify the `cagg_watermark` function call is not working because we're checking for window function usage on the query tree but actually this is a current limitation when creating a new Continuous Aggregate, but users can use window functions when querying it. Fixed it by removing the check for `query->hasWindowFuncs` to prevent the process of constification of the `cagg_watermak` function call. Fixes #6722 (cherry picked from commit a1cd7c4)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.14.x #6728 +/- ##
==========================================
- Coverage 79.73% 79.68% -0.06%
==========================================
Files 190 190
Lines 37343 37191 -152
Branches 9483 9439 -44
==========================================
- Hits 29777 29637 -140
- Misses 3147 3163 +16
+ Partials 4419 4391 -28 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of #6726: Fix constify cagg_watermark using window functions.
The original issue is #6722.
This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore.
For more details, please see the documentation
Original description
Fix constify cagg_watermark using window functions
When querying a realtime Continuous Aggregate using window functions the new planner optimization to constify the
cagg_watermarkfunction call is not working because we're checking for window function usage on the query tree but actually this is a current limitation when creating a new Continuous Aggregate, but users can use window functions when querying it.Fixed it by removing the check for
query->hasWindowFuncsto prevent the process of constification of thecagg_watermakfunction call.Fixes#6722