Add support for secondary dimensions #6021
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pmwkaa, @akuzm: please review this pull request.
|
nikkhils
force-pushed
the
secondary_dims
branch
4 times, most recently
from
2ea9d83
to
49f9056
Compare
Codecov Report
@@ Coverage Diff @@
## main #6021 +/- ##
==========================================
- Coverage 81.38% 81.29% -0.10%
==========================================
Files 243 243
Lines 55940 56011 +71
Branches 12385 12399 +14
==========================================
+ Hits 45526 45532 +6
- Misses 8088 8108 +20
- Partials 2326 2371 +45
... and 47 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nikkhils
force-pushed
the
secondary_dims
branch
from
4fa1f51
to
e87f4b3
Compare
Allow users to specify a specific column to be used as a secondary dimension using the add_dimension() API. A secondary dimension does not participate in partitioning of the data. Such a secondary dimension will be used for chunk pruning if the WHERE clause of a SQL query specifies ranges on such a column.
Create dimension_slide and chunk_constraint entries for chunks belonging to a hypertable which has secondary dimensions on it. The dimension slice entry will have -inf/+inf as start/end range for this secondary dimension and the chunk_constraint entry will refer back to it. This start/end range will be refreshed later.
nikkhils
force-pushed
the
secondary_dims
branch
from
e87f4b3
to
7f9032c
Compare
|
Closing this. A newer draft PR #6727 covers this same functionality now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify a specific column to be used as a secondary dimension using the add_dimension() API. A secondary dimension does not participate in partitioning of the data. Such a secondary dimension will be used for chunk pruning if the WHERE clause of a SQL query specifies ranges on such a column.
Disable-check: force-changelog-file
Disable-check: commit-count