fix: Improve doing_it_wrong messages for using deprecated parameters in Timber::get_post(), Timber::get_attachment() and Timber::get_image() #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Timber::get_attachment() and Timber::get_image()
Levdbas
approved these changes
May 14, 2024
|
@gchtr , these tests now succeed as well :D |
This was referenced May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
Error messages might be confusing if you use
Timber::get_image()with a wrong parameter. You will get error messages that say there was an error withTimber::get_post().Solution
Use different error messages per method.
Impact
Better understanding of error.
Usage Changes
None.
Considerations
This can be removed in a next major version.
Testing
Not in particular.