fix: fix regression where crops with the default crop setting would s… #2998
Conversation
…queeze the image inside dimensions instead of cropping.
|
@nlemoine , could you help me with this? The tests are false positives from what I can see from local tests. They just run fine. How to proceed? |
|
@timber/rangers , only one error remains in the testExternalImageWithExternalUrlAndNoImageExtension test. @gchtr , you introduced that test a few months ago. Could you shine your light on why path would be empty? Running the tests locally works just fine. Edit: I see this PR runs into the same issues: https://github.com/timber/timber/actions/runs/9073988724/job/24932007649?pr=2999 |
|
@Levdbas I fixed it! Just joking. I had no idea why the error happened so I just re-ran the failing tests. It looks like there was some issue in the containers used for the tests. I also ran into this issue on a site I’m working on, and I can confirm that this fixes the issue. Just a note for anyone running into this and wondering why an image doesn’t look right after the Update: Images sizes need to be deleted and generated again for the fix to be applied to the image. |
Related:
Issue
In 18bf358 a bug was introduced where the default crop parameter would lead to squeezing the image inside a confined space. instead of cropping into the image.
Solution
Revert that if statement to the way it was in 1.x
Impact
Working crops!
Usage Changes
No.
Considerations
See
Testing
no.