fix: Fix deprecation notice since twig 3.10 to now use EscaperRuntime… #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of EscaperExtension
nlemoine
approved these changes
May 13, 2024
gchtr
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
Since Twig 3.10 the old methods of adding additional escapers is deprecated.
Solution
Use the new escaping extension instead with a fallback to use the old escapers. Since we support twig from version 3.5 and onward.
I took the if/else setup from here: https://github.com/symfony/ux/blob/796dd587827f2bb849064c33cc4e053c39e0a0e9/src/TwigComponent/src/Twig/TwigEnvironmentConfigurator.php
Impact
No more deprecation notices.
Usage Changes
No.
Considerations
No.
Testing
Yes. I added a test to test one of the old escaper methods so we can test that functionality as long as we support that.