Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test Rector to upgrade code for PHP 8.1 #2977

Merged
merged 13 commits into from May 15, 2024
Merged

feat: Test Rector to upgrade code for PHP 8.1 #2977

merged 13 commits into from May 15, 2024

Conversation

nlemoine
Copy link
Member

Just giving Rector a try :)

Issue

Solution

Impact

Usage Changes

Considerations

Testing

Levdbas
Levdbas previously approved these changes Apr 30, 2024
@Levdbas Levdbas added this to the 2.2.0 milestone May 3, 2024
@gchtr
Copy link
Member

gchtr commented May 15, 2024

Just to understand this correctly: We would use this once we move to PHP 8.1 as a minimum required version?

- fix Timber\Core::__isset() not returning boolean
Levdbas
Levdbas previously approved these changes May 15, 2024
@Levdbas
Copy link
Member

Levdbas commented May 15, 2024

would use this once we move to PHP 8.1 as a minimum required version?

I think we could run this from time to time when we have a new release to see if we introduced new code that could be modernized, right @nlemoine ?

@nlemoine
Copy link
Member Author

I think we could run this from time to time when we have a new release to see if we introduced new code that could be modernized, right @nlemoine ?

Actually, since there is a rector task for GrumPHP, we should run this at every commit, avoiding the need for "modernizing" the code base from time to time.

src/FunctionWrapper.php Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented May 15, 2024

Coverage Status

coverage: 88.006% (+0.3%) from 87.677%
when pulling 2e1fe0a on feat-rector
into 66e92a5 on 2.x.

@nlemoine nlemoine merged commit 9edf999 into 2.x May 15, 2024
24 of 26 checks passed
@nlemoine nlemoine deleted the feat-rector branch May 15, 2024 13:38
This was referenced May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants