Fix for infinite loops in post.excerpt in specific cases

[Levdbas]

Related:

• post.preview causes infinite loops #2041

Issue

When you render a post preview in a dynamic block this will cause an infinite loop.

Solution

When fetching the content from the excerpt method, run the excerpt_remove_blocks function inside the content() method.

Impact

Post previews will probably render faster since now we are not parsing blocks anymore.

Usage Changes

I added a third parameter to the content() method but this is optional.

Considerations

Nothing I can think about right now.

Testing

Test and additional assets added to register a block, render the block via a render callback and then run a post.preview inside it. if you remove the suggested changes in Post.php and run the test it will cause a timeout which shows up in PHPunit as a segmentation fault.

[Levdbas]

@gchtr , I reverted the parameters to the old ones.

[gchtr]

This looks good to me 👍.

I’m not a huge fan of adding the $remove_blocks flag as an additional parameter, though. But I can’t think of anything better at the moment.

@nlemoine Anything to add here?

[Levdbas]

This looks good to me 👍.

I’m not a huge fan of adding the $remove_blocks flag as an additional parameter, though. But I can’t think of anything better at the moment.

@nlemoine Anything to add here?

I had the same feeling, Ideally you would want to know what the caller is of the content method is, so you can apply the remove block logic that way. But no idea how to solve that. Duplication the content method is also not the way to go in my opinion.

[nlemoine]

But no idea how to solve that

Using debug_backtrace() ;)

Sorry, I didn't dig that topic much, I trust you guys on this 👍