Update https #2947
Merged
Update https #2947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlemoine
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In the light of better security, a bit of low hanging fruit. We still had a lot of http:// links in our docblocks, .md files and other supporting files.
Solution
Lets update our entire codebase with updated links from http:// to https://
Impact
Less redirects to handle and some better examples. Only real code change is in Comment.php. Where we would refer to gravatar via a non secured url. To update that as well I updated some tests as well.
Usage Changes
None
Considerations
Break the changes up in multiple PR's?
Testing
Tests are changed for the codechange in Comment.php