2.x Fix PHPStan issues on level 1 #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gchtr
added
the
Ready for Review
Levdbas
approved these changes
May 18, 2023
nlemoine
approved these changes
May 18, 2023
|
Great, thanks for the feedback! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
Issue
There are various issues raised by PHPStan on level 1.
The level 0 issues in #2659 should be resolved first before merging this in.
Solution
This pull request resolves them. It’s mainly missing property definitions.
Impact
None.
Usage Changes
None.
Considerations
None.
Testing
Covered through existing tests.