-
-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x #1617
Conversation
tests/test-timber-menu.php
Outdated
|
||
// Menu item with _menu_item_target set to '' | ||
$item = $items[2]; | ||
$this->assertFalse( '_self', $item->target() ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gchtr wanted to check on this test (it's failing right now). Should $item->target()
register as _self
or false
in this scenario?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarednova Oh! I don’t know why it wasn’t failing for me. But that should probably be:
$this->assertEquals( '_self', $item->target() );
It should definitely return _self
. I copied the assertFalse
from the test above and forgot to change the assertion method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, that's what I thought! I have a patch I'll pull in to 2.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarednova See #2019.
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
============================================
- Coverage 94.83% 94.31% -0.53%
+ Complexity 1527 1507 -20
============================================
Files 48 48
Lines 3585 3799 +214
============================================
+ Hits 3400 3583 +183
- Misses 185 216 +31
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
============================================
- Coverage 94.83% 94.31% -0.53%
+ Complexity 1527 1507 -20
============================================
Files 48 48
Lines 3585 3799 +214
============================================
+ Hits 3400 3583 +183
- Misses 185 216 +31
Continue to review full report at Codecov.
|
4 similar comments
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
============================================
- Coverage 94.83% 94.31% -0.53%
+ Complexity 1527 1507 -20
============================================
Files 48 48
Lines 3585 3799 +214
============================================
+ Hits 3400 3583 +183
- Misses 185 216 +31
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
============================================
- Coverage 94.83% 94.31% -0.53%
+ Complexity 1527 1507 -20
============================================
Files 48 48
Lines 3585 3799 +214
============================================
+ Hits 3400 3583 +183
- Misses 185 216 +31
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
============================================
- Coverage 94.83% 94.31% -0.53%
+ Complexity 1527 1507 -20
============================================
Files 48 48
Lines 3585 3799 +214
============================================
+ Hits 3400 3583 +183
- Misses 185 216 +31
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1617 +/- ##
============================================
- Coverage 94.83% 94.31% -0.53%
+ Complexity 1527 1507 -20
============================================
Files 48 48
Lines 3585 3799 +214
============================================
+ Hits 3400 3583 +183
- Misses 185 216 +31
Continue to review full report at Codecov.
|
This reverts commit b57670d.
# Conflicts: # README.md
# Conflicts: # bin/timber.php # lib/Timber.php # readme.txt
Timber 2.0 is released: https://github.com/timber/timber/releases/tag/2.0.0. We kept the |
One major version bump of Timber equals 5 children from a female 👱🏻♀️ |
Ticket: #1580
This will track the progress and tests for
2.x
intomaster