engine: respect the native docker-compose order. Fixes part of issue #2210 #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicks
force-pushed
the
nicks/issue2210/order
branch
from
92f95f6
to
ba47b32
Compare
maiamcc
approved these changes
Sep 20, 2019
| f := newTestFixture(t) | ||
| defer f.TearDown() | ||
|
|
||
| sancho := NewSanchoFastBuildDCManifest(f) |
There was a problem hiding this comment.
can you make a note somewhere of what the order would be if we weren't respecting DC order and let the k8s-unbuilt logic handle this?
nicks
force-pushed
the
nicks/issue2210/order
branch
from
ba47b32
to
b938024
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @maiamcc,
Please review the following commits I made in branch nicks/issue2210/order:
92f95f6 (2019-09-19 17:07:12 -0400)
engine: respect the native docker-compose order. Fixes part of issue #2210