Firmware command #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dehanj
reviewed
Apr 1, 2024
dehanj
reviewed
Apr 1, 2024
mchack-work
force-pushed
the
firmware-commands
branch
from
d204365
to
3b5d511
Compare
dehanj
reviewed
Apr 2, 2024
dehanj
force-pushed
the
firmware-commands
branch
from
3b5d511
to
bcafa72
Compare
dehanj
approved these changes
Apr 2, 2024
Instead of providing a function to get a pre-hashed signature, SignPh(), we provide a function to ask the signer app for a hash digest of some bytes of the firmware, GetFWDigest(). See corresponding changes in tkey-device-signer.
mchack-work
force-pushed
the
firmware-commands
branch
from
bcafa72
to
77b1b8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace SignPH() with GetFWDigest()
See tillitis/tkey-sign-cli#21 for a way of testing this.