add some global error handling options #8
+32
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
approved these changes
Oct 9, 2018
chancancode
approved these changes
Oct 9, 2018
| }) | ||
|
|
||
| raise e | ||
| if Slackathon.report_errors? |
| @@ -17,4 +17,21 @@ def self.queue | |||
| def self.queue=(queue) | |||
| @queue = queue | |||
| end | |||
|
|
|||
| def self.report_errors? | |||
| @report_errors = true unless defined?(@report_errors) | |||
There was a problem hiding this comment.
We should probably just change this file to eagerly assign the default values right after we define the setter. Do you think that would break anything?
|
@chancancode should we just merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We probably don't need to both report an error back to Slack and re-raise it (depending on the ActiveJob backend config, this may result in the same failed command being run multiple times). This sets the default to only printing the error message.