Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make recommendation against defer less strict #564

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Mar 31, 2021

  1. Make recommendation against defer less strict

    There are plenty of cases, especially when writing tests, where it makes more sense to use `defer` than to do something like
    ```
    let resolvePromise;
    let promise = new Promise(resolve => {
      resolvePromise = resolve;
    });
    stubReturn(promise);
    // test loading state
    resolvePromise(...);
    // test resolved state
    ```
    mongoose700 committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    0d3206a View commit details
    Browse the repository at this point in the history