Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make example code import and use the right modules in the right way #555

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make example code import and use the right modules in the right way #555

wants to merge 1 commit into from

Commits on Mar 18, 2020

  1. Make example code import and use the right modules in the right way 

    The former example where not technically wrong but pretty misleading,
since they suggested `Promise` (the one that can be used in
`new Promise`) is the default export of the `rsvp` package when it isn't.
Ideally when using the default import it should be called `RSVP` rather
then `Promise` but in fact neither of the code example require to use
that default export at all so I removed using that in the examples
entirely.
    @ohcibi
    ohcibi committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    cf22ba2 View commit details
    Browse the repository at this point in the history