Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new namespace #460

Closed
wants to merge 12 commits into from
Closed

new namespace #460

wants to merge 12 commits into from

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented May 18, 2017

moving helpers to new namespace as described #261

@bekzod bekzod force-pushed the new-namespace branch 4 times, most recently from 185dd64 to a3c5703 Compare May 19, 2017 19:24
@bekzod
Copy link
Contributor Author

bekzod commented May 19, 2017

this is what is left in RSVP namespace after movement

export {
  asap,
  Promise,
  EventTarget,
  configure,
  on,
  off,
  async
};

or everything should be moved to Promise namespace ?

@stefanpenner
Copy link
Collaborator

or everything should be moved to Promise namespace ?

no that looks correct

@stefanpenner
Copy link
Collaborator

But whats the plan for ember? We likely need a compat shim or something?

@bekzod
Copy link
Contributor Author

bekzod commented May 22, 2017

don't have much experience with compatibility/shims, if you lead/guide me I can do whatever you have in mind

@stefanpenner
Copy link
Collaborator

@bekzod sounds good. I'll take time later this week to put together some thoughts :)

@bekzod bekzod force-pushed the new-namespace branch 3 times, most recently from 1c0d5b6 to c933968 Compare July 25, 2017 09:59
@bekzod bekzod changed the title new namespace (wip) new namespace Jul 25, 2017
@bekzod
Copy link
Contributor Author

bekzod commented Jan 8, 2018

@stefanpenner ping should I update this PR ? what would be the plan to do depreciation and aliasing in ember core level and just drop old namespace in RSVP level?

@locks locks self-assigned this Jan 11, 2018
@stefanpenner
Copy link
Collaborator

I personally prefer this, but I worry re: churn.

@rwjblue would love your thoughts on this as well.

@wagenet
Copy link
Contributor

wagenet commented Jan 22, 2020

Closing due to staleness.

@wagenet wagenet closed this Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants