Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a type error when exactOptionalPropertyTypes is enabled #339

Merged
merged 1 commit into from Mar 19, 2024

Conversation

boris-petrov
Copy link
Contributor

@wagenet
Copy link
Collaborator

wagenet commented Mar 14, 2024

It seems like there would be a lot of other things affected by this, including the line immediately above: queryParams?: Dict<unknown>;

@boris-petrov
Copy link
Contributor Author

Right, this definitely doesn't fix all issues in this repo concerning exactOptionalPropertyTypes but it does fix all issues in a user's Ember app when using exactOptionalPropertyTypes.

@wagenet wagenet merged commit 7b65768 into tildeio:master Mar 19, 2024
4 checks passed
@boris-petrov boris-petrov deleted the exactOptionalPropertyTypes branch March 20, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript errors when exactOptionalPropertyTypes is enabled
2 participants