Fix followRedirects when source is async and destination is sync #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
added a commit
to davidtaylorhq/ember.js
that referenced
this pull request
Nov 16, 2023
The current implementation of `Transition#followRedirects()` is identical to the logic here: it catches rejections, and then checks for any other `activeTransition`. Therefore, this commit introduces no change in behavior. But, if/when tildeio/router.js#335 lands, it will means we can take advantage of that fix for ApplicationInstance#visit.
This was referenced Nov 16, 2023
The previous implementation of `followRedirects()` would catch a transition rejection and check the router for an `activeTransition`. This can become problematic in async situations because the destination transition may have resolved before the `reject` is scheduled on the previous transition. One such case is when redirecting from an async model hook to a destination route with synchronous model hooks. This commit updates the `followRedirects()` logic to explicitly follow the redirect chain rather than relying on the presence of an `activeTransition`. This makes following redirects work correctly regardless of any scheduling concerns. This problem has been noted in the context of the `visit()` test helper: - emberjs/ember-test-helpers#332 - emberjs/ember.js#17150
davidtaylorhq
force-pushed
the
redirect-following-fix
branch
from
7b0cb53
to
787cfbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
followRedirects()would catch a transition rejection and check the router for anactiveTransition. This can become problematic in async situations because the destination transition may have resolved before therejectis scheduled on the previous transition. One such case is when redirecting from an async model hook to a destination route with synchronous model hooks.This commit updates the
followRedirects()logic to explicitly follow the redirect chain rather than relying on the presence of anactiveTransition. This makes following redirects work correctly regardless of any scheduling concerns.This problem has been noted in the context of the
visit()test helper:visittest helper to fail emberjs/ember.js#17150