Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failing test for native promises that return another transition. #310

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Add failing test for native promises that return another transition. #310

wants to merge 5 commits into from
+103 −1

Commits on Nov 10, 2020

  1. Failing test for TransitionAborted via router.transitionTo within… 

    … async hook.
    @rwjblue @stefanpenner
    rwjblue authored and stefanpenner committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    5ea1d83 View commit details
    Browse the repository at this point in the history

  2. tidy-up test

    @stefanpenner
    stefanpenner committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    512836c View commit details
    Browse the repository at this point in the history

  3. Only async function is required to replicate this issue, sleep + ex… 

    …tra promise is not.
    @stefanpenner
    stefanpenner committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    1d5fdc3 View commit details
    Browse the repository at this point in the history

  4. consistency

    @stefanpenner
    stefanpenner committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    3ea8a78 View commit details
    Browse the repository at this point in the history

  5. improve test name clarity

    @stefanpenner
    stefanpenner committed Nov 10, 2020
    Configuration menu
    Copy the full SHA
    67a7868 View commit details
    Browse the repository at this point in the history