Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URL Update Method for QP-replacement during Transition #303

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix URL Update Method for QP-replacement during Transition #303

wants to merge 3 commits into from
+130 −11

Commits on Aug 14, 2020

  1. test: extract consumeAllFinalQueryParams helper

    @alexlafroscia
    alexlafroscia committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    325e34a View commit details
    Browse the repository at this point in the history

  2. test: add failure for QP replacement transition

    @alexlafroscia
    alexlafroscia committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    fc2177d View commit details
    Browse the repository at this point in the history

  3. fix: link interrupting QP-only transition to the active transition 

    This makes a QP-only transition that updates an active transition actually replace the active transition, rather than them both happening.

We also keep track of whether the interrupted transition was intending to update the URL, because a replacement that interrupts an update should still update the URL.
    @alexlafroscia
    alexlafroscia committed Aug 14, 2020
    Configuration menu
    Copy the full SHA
    0702b71 View commit details
    Browse the repository at this point in the history