[BUGFIX] Incorrect logging of messages with sequence numbers (tildeio/router.js#281) #282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong "arg[ument]s" variable is being checked for length, which results in logging calls to log always being logged wrong. (#281)
Current:
log(router, "foo")
=>Transition #: foo
(arguments.length === 2, args.length === 1)log(router, 1, "foo)
=>1
(arguments.length === 3, args.length === 2)Expected:
log(router, "foo")
=>foo
log(router, 1, "foo)
=>Transition #1: foo