Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query string is generated, the
generateQueryString
function sorts the params alphabetically.This behavior isn't exactly flawed, but it's unexpected and provides no meaningful benefit. If a developer always wants their keys to be sorted, it should be done before passing them to the recognizer. The current implementation makes it impossible to choose how query params are sorted.
I ran into an annoyance with this recently when I changed a route to always be redirected to from an index route at the same level of the hierarchy; this is done by calling
replaceWith
and passing the current queryParams to that function. The queryParams are passed in the correct order that's already expected, but what happens now that the queryParams get sorted by the recognizer is that my acceptance tests (which assert that the current URL is correct) for the target route have several failures now that the queryParams are sorted differently. It's not something that can't be easily fixed, but it's extra time the developer needs to spend and is overall unexpected.