Skip to content

Commit

Permalink
Merge pull request #57 from tildeio/fix-types
Browse files Browse the repository at this point in the history
Fix types/build
  • Loading branch information
chancancode committed Oct 17, 2023
2 parents df6f179 + df91563 commit fa64164
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 9 deletions.
11 changes: 4 additions & 7 deletions addon/this-fallback-helper.ts
Expand Up @@ -3,9 +3,9 @@ import { deprecate } from '@ember/debug';
import { get } from '@ember/object';
import { assertIsDeprecation } from 'ember-this-fallback/types/deprecations';

type Positional<T, K extends keyof T> = [
context: T,
path: K,
type Positional = [
context: object,
path: string,
deprecationJson: string | false
];

Expand All @@ -16,10 +16,7 @@ type Positional<T, K extends keyof T> = [
* will be called with those params.
*/
const thisFallbackHelper = helper(
<T, K extends keyof T>([context, path, deprecationJson]: Positional<
T,
K
>) => {
([context, path, deprecationJson]: Positional) => {
if (deprecationJson) {
const deprecation = assertIsDeprecation(JSON.parse(deprecationJson));
deprecate(...deprecation);
Expand Down
2 changes: 1 addition & 1 deletion lib/tsconfig.json
Expand Up @@ -106,6 +106,6 @@

/* Completeness */
// "skipDefaultLibCheck": true, /* Skip type checking .d.ts files that are included with TypeScript. */
"skipLibCheck": false /* Skip type checking all .d.ts files. */
"skipLibCheck": true /* Skip type checking all .d.ts files. */
}
}
3 changes: 2 additions & 1 deletion tsconfig.json
Expand Up @@ -13,7 +13,8 @@
"ember-this-fallback/test-support": ["addon-test-support"],
"ember-this-fallback/test-support/*": ["addon-test-support/*"],
"*": ["types/*"]
}
},
"skipLibCheck": true
},
"include": [
"app/**/*",
Expand Down

0 comments on commit fa64164

Please sign in to comment.