Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: introduce codeQL issue #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TimoSairiala
Copy link

This PR tries to create a new coding issue that CodeQL should be able to find.
It is done to demonstrate the CodeQL functionality

@@ -794,6 +794,8 @@
cmdlen++;
g_command[cmdlen] = '\0';

ret = system(g_command);

Check failure

Code scanning / CodeQL

Uncontrolled data used in OS command Critical

This argument to an OS command is derived from
user input (a command-line argument)
, dangerously concatenated into
snprintf output argument
, and then passed to system(cmd).
This argument to an OS command is derived from
user input (a command-line argument)
, dangerously concatenated into
snprintf output argument
, and then passed to system(cmd).
This argument to an OS command is derived from
user input (a command-line argument)
, dangerously concatenated into
strcat output argument
, and then passed to system(cmd).
This argument to an OS command is derived from
user input (a command-line argument)
, dangerously concatenated into
strcat output argument
, and then passed to system(cmd).
This argument to an OS command is derived from
user input (a command-line argument)
, dangerously concatenated into
snprintf output argument
, and then passed to system(cmd).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant