guivm: Passthrough the multimedia keys #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerox9
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Nerox9
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Nerox9
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Nerox9
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Nerox9
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Nerox9
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
Thinkpad multimedia function keys have a different input device. ACPI backlight option should be overridden as vendor in kernel to use the all function keys in the same input. Signed-off-by: Berk Arslan <berk.arslan@unikie.com>
Nerox9
temporarily deployed
to
internal-build-workflow
GitHub Actions
Inactive
|
Please update the testing section to include instructions on how this should be tested and what are the expected results. |
|
Tested on X1
|
milva-unikie
added
the
Tested on Lenovo X1 Carbon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Thinkpad multimedia function keys have a different input device than keyboard itself. It is connected to guivm with udev and brightness keybinds are set in labwc.
Checklist for things done
x86_64aarch64riscv64nix flake check --accept-flake-configand it passesTesting
Use F5 and F6 keys to observe brightness change on the screen backlight in GUIVM.