Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networking: module for static names #584

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

vilvo
Copy link
Contributor

@vilvo vilvo commented Apr 30, 2024

Description of changes

Todo

  • @tervis-unikie to allocate static IP for the gui-vm.nix based on netvm.nix
  •  disable DHCP in appvms, assign static IPs to app-vms using the appvm template and index(?) (and subnet param?)

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@vilvo vilvo temporarily deployed to internal-build-workflow April 30, 2024 13:02 — with GitHub Actions Inactive
@vilvo vilvo mentioned this pull request Apr 30, 2024
13 tasks
@vilvo vilvo marked this pull request as draft April 30, 2024 13:05
vilvo and others added 2 commits May 3, 2024 09:14
* based on decisions to use static names over internal DNS
  tiiuae#427
* removes dnsmasq and dhcp from net-vm to other guests
  * WIP: static IPs not assigned to other guests yet

Signed-off-by: Ville Ilvonen <ville.ilvonen@unikie.com>
Signed-off-by: Tero Tervala <tero.tervala@unikie.com>
192.168.100.4 chromium-vm
192.168.100.5 zathura-vm
192.168.100.6 element-vm
192.168.100.7 gui-vm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we can keep gui-vm IP to older value 192.168.100.3
and what about ghaf-host IP assignment?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it would have been preferable too, but I did not change the address in hosts.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest we can keep gui-vm IP to older value 192.168.100.3 and what about ghaf-host IP assignment?

I'm fine with this. In the end, the ip addresses won't matter. When all of this works, we can use the names only for inter-vm and it will allow us even to change the network if needed/preferred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants