Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove libcamera from pipewire #577

Closed
wants to merge 1 commit into from
Closed

Remove libcamera from pipewire #577

wants to merge 1 commit into from

Conversation

brianmcgillion
Copy link
Collaborator

Pipewire pulls in libcamera, which is currently unused. Libcamera causes many builds to fail because of the FOD creating a different result when built on different machines.

error: hash mismatch importing path '/nix/store/glazsqngfws5m5m8nzq5mxai6rljw1lc-libcamera-0.0.5';
specified: sha256:0vk0r73zczhg58zqrk2fz6wa648bdxrr1pza4vjgglglndx6d4dv
got:       sha256:1gffy40qlljmb74vnb074b1yc8ippd3cp41l7z4rmwyja0i969v0

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@brianmcgillion
Remove libcamera from pipewire
4a3044b 
Pipewire pulls in libcamera, which is currently unused. Libcamera
causes many builds to fail because of the FOD creating a different
result when built on different machines.

````
error: hash mismatch importing path '/nix/store/glazsqngfws5m5m8nzq5mxai6rljw1lc-libcamera-0.0.5';
specified: sha256:0vk0r73zczhg58zqrk2fz6wa648bdxrr1pza4vjgglglndx6d4dv
got:       sha256:1gffy40qlljmb74vnb074b1yc8ippd3cp41l7z4rmwyja0i969v0
````

Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow April 28, 2024 19:00 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow April 29, 2024 02:52 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow April 29, 2024 05:39 — with GitHub Actions Inactive
@Mic92
Copy link
Collaborator

Mic92 commented Apr 29, 2024

I fixed the binary reproduciblity of libcamera in this pull request: NixOS/nixpkgs#307719

@brianmcgillion brianmcgillion temporarily deployed to internal-build-workflow April 30, 2024 09:11 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion deleted the remove-libcamera branch May 17, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brianmcgillion @Mic92