Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offline installer fix #575

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Offline installer fix #575

wants to merge 2 commits into from

Conversation

Mic92
Copy link
Collaborator

@Mic92 Mic92 commented Apr 23, 2024

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:43 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:43 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:43 — with GitHub Actions Inactive
@Mic92 Mic92 marked this pull request as draft April 23, 2024 17:44
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:44 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:44 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:44 — with GitHub Actions Inactive
Mic92
Mic92 commented Apr 23, 2024
View reviewed changes
tests/installer/default.nix Outdated
@@ -40,7 +40,7 @@ pkgs.nixosTest {

print(machine.succeed("tty"))

machine.succeed("disko-install --disk ${disk} /dev/vdb --flake ${self}#${testConfig}")
machine.succeed("disko-install --write-efi-boot-entries --disk ${disk} /dev/vdb --flake ${self}#${testConfig}")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@remimimimimi that's a very subtle difference. Let me fix this in nixpkgs actually.
The issue is that disko-install needs to override the NixOS configuration to disable writing efi vars as the default because it would be not fit as a USB flasher if it would make the system it's running on unbootable.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That in turn triggered a rebuild of systemd-boot-builder.

remimimimimi and others added 2 commits April 23, 2024 19:50
@remimimimimi @Mic92
Add installer test
ed67a2b 
Signed-off-by: Valentin Kharin <valentin.kharin@unikie.com>
@Mic92
fix offline installer
9d7b69a 
Signed-off-by: Jörg Thalheim <joerg@thalheim.io>
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:51 — with GitHub Actions Inactive
@Mic92 Mic92 temporarily deployed to internal-build-workflow April 23, 2024 17:51 — with GitHub Actions Inactive
@Mic92
Copy link
Collaborator Author

Mic92 commented Apr 23, 2024

I also fixed NixOS to not require boot install script checks rebuilds when the nixos configuration changes: NixOS/nixpkgs#306339

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @remimimimimi