New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn reg_file_data_sampling=off (experiment, never merge) #563
base: main
Are you sure you want to change the base?
Conversation
I ran performance tests on X1, this PR had no effect on them. Memory test results are still low. |
Bisect step 1/11 Memory test results are at the normal high level. |
Bisect step 2/11 Memory test results are at the normal high level. |
Bisect step 3/11 Memory test results are at the normal high level. |
Bisect step 4/11 Memory test results are low. |
Bisect step 5/11 Memory test results are at the normal high level. |
Bisect step 6/11 Memory test results are low. |
Bisect step 7/11 Memory test results are at the normal high level. |
Bisect step 8/11 Memory test results are low. |
Bisect step 9/11 Memory test results are low. |
Bisect step 10/11 Memory test results are at the normal high level. |
Bisect step 11/11 Memory test results are low. |
Bisect step 12/11 Memory test results are at the normal high level. |
Bisect step 13/11 Memory test results are low. bbaca2d369cf3a38492b8dfe4aaa541b957eee2d is the first bad commit. |
Latest commit returns memory test results to the normal high level. |
That fixed the problem, results are good again. |
Description of changes
Checklist for things done
x86_64
aarch64
riscv64
nix flake check --accept-flake-config
and it passesTesting