Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn reg_file_data_sampling=off (experiment, never merge) #563

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Apr 12, 2024

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@avnik avnik temporarily deployed to internal-build-workflow April 12, 2024 11:46 — with GitHub Actions Inactive
@avnik avnik marked this pull request as draft April 12, 2024 11:46
@milva-unikie
Copy link

I ran performance tests on X1, this PR had no effect on them. Memory test results are still low.

@milva-unikie
Copy link

Bisect step 1/11
github:NixOS/nixpkgs/76ff5056a904a9d0e16b811f3af25d5950b5f339

Memory test results are at the normal high level.

@milva-unikie
Copy link

Bisect step 2/11
github:NixOS/nixpkgs/307ada3fc4d35f7f35feb9a0edab94f798092c1b

Memory test results are at the normal high level.

@milva-unikie
Copy link

Bisect step 3/11
386047017bed0ea4ec985bec134b4f8c2b5bd199

Memory test results are at the normal high level.

@milva-unikie
Copy link

Bisect step 4/11
fb8b096a243ae71d62e9be83ea0c2a2f6d50ea69

Memory test results are low.

@milva-unikie
Copy link

Bisect step 5/11
e42f762af098be9e16b8677441e011511a1f81e9

Memory test results are at the normal high level.

@milva-unikie
Copy link

Bisect step 6/11
033e72165ef3f3b6be6d901444ed5e5d0ef699aa

Memory test results are low.

@milva-unikie
Copy link

Bisect step 7/11
f53f26121baf6cedab75e46f216926ee6d634a3d

Memory test results are at the normal high level.

@milva-unikie
Copy link

Bisect step 8/11
63fc8d8df880141981b42917c0913c38a8d15264

Memory test results are low.

@milva-unikie
Copy link

Bisect step 9/11
cadd303c9a1a1b4394cd916bd9911cdc9b67d52a

Memory test results are low.

@milva-unikie
Copy link

Bisect step 10/11
5b44915269e6ebab5eafcbfc273e6cbdcecd2827

Memory test results are at the normal high level.

@milva-unikie
Copy link

Bisect step 11/11
a03387a1edd4b72e74912b47c97e2b5ac23642b3

Memory test results are low.

@milva-unikie
Copy link

Bisect step 12/11
7dccf6334c57d8c8f5411d1ee6e8328057539fca

Memory test results are at the normal high level.

@milva-unikie
Copy link

Bisect step 13/11
bbaca2d369cf3a38492b8dfe4aaa541b957eee2d

Memory test results are low.

bbaca2d369cf3a38492b8dfe4aaa541b957eee2d is the first bad commit.

@avnik avnik temporarily deployed to internal-build-workflow April 25, 2024 10:35 — with GitHub Actions Inactive
@milva-unikie
Copy link

Latest commit returns memory test results to the normal high level.

@avnik avnik temporarily deployed to internal-build-workflow April 29, 2024 12:00 — with GitHub Actions Inactive
@milva-unikie
Copy link

That fixed the problem, results are good again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants