Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo. Never merge. Reproduce of correct cross-build of electron #540

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Demo. Never merge. Reproduce of correct cross-build of electron #540

wants to merge 1 commit into from

Conversation

avnik
Copy link
Contributor

@avnik avnik commented Apr 3, 2024

Reproduce of correct cross-build electron and chromium after applying 16ea8d447b9dab5ec4676ba969b79c22d4cab1e9

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

@avnik avnik temporarily deployed to internal-build-workflow April 3, 2024 15:45 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion marked this pull request as draft April 3, 2024 15:51
@avnik
Demo. Never merge. Reproduce of correct cross-build of electron
ecfb951 
Reproduce of correct cross-build electron and chromium after applying
16ea8d447b9dab5ec4676ba969b79c22d4cab1e9

Signed-off-by: Alexander Nikolaev <alexander.nikolaev@unikie.com>
@avnik avnik force-pushed the avnik/demo-of-electron-fixup-in-stable branch from 2af404c to ecfb951 Compare April 3, 2024 18:40
@avnik avnik temporarily deployed to internal-build-workflow April 3, 2024 18:40 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@avnik