Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: Change netvm hypervisor to cloud-hypervisor #532

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

slakkala
Copy link

Description of changes

Use cloud-hypervisor for Net VM guest instead of qemu.

Also requires change of the share protocol from 9p to virtiofs, since cloud-hypervisor does not support 9p.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run nix flake check --accept-flake-config and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status

Testing

Tested by building an X1 image and running it, verifying that network configuration and connection works via the top bar applet.

@slakkala slakkala temporarily deployed to internal-build-workflow March 22, 2024 09:41 — with GitHub Actions Inactive
@slakkala slakkala temporarily deployed to external-build-workflow March 22, 2024 09:41 — with GitHub Actions Inactive
@slakkala slakkala marked this pull request as draft March 22, 2024 09:41
Signed-off-by: Santtu Lakkala <santtu.lakkala@unikie.com>
@slakkala slakkala temporarily deployed to internal-build-workflow March 22, 2024 09:42 — with GitHub Actions Inactive
@slakkala slakkala temporarily deployed to external-build-workflow March 22, 2024 09:42 — with GitHub Actions Inactive
@leivos-unikie
Copy link
Contributor

leivos-unikie commented Apr 9, 2024

EDIT NOTE:
This drop in performance is not related to this PR. Turned out it has already been in ghaf mainline for some time and gone unnoticed. Since I did rebase the performance problem got into my build. If building from this PR at current state without rebase the performace is actually at normal level.

There was discussion yesterday that this PR would need some preliminary testing.

Since the branch was 21 commits behind mainline I did rebase before building:

git clone https://github.com/slakkala/ghaf.git
git checkout dev/cloud-hypervisor
git remote add upstream https://github.com/tiiuae/ghaf.git
git fetch upstream
git rebase upstream/main

Built the installer
nix build .#lenovo-x1-carbon-gen11-debug-installer
and installed ghaf on the internal nvme of Lenovo-X1.

Tested

  • all apps launch
  • ci-test-automation tests pass
  • ci-test-automation 1 thread memory read/write results show around 25% drop in performance

Lenovo-X1_Sysbench test in VMs on LenovoX1_memory_write_1thread

Lenovo-X1_Sysbench test in VMs on LenovoX1_memory_read_1thread

Ghaf-host:
Lenovo-X1_Memory Write One thread test
Lenovo-X1_Memory Read One thread test

@leivos-unikie
Copy link
Contributor

Tested on Orin AGX
Built flash script with nix build .#nvidia-jetson-orin-agx-debug-flash-script

  • net-vm does not start and cannot be started manually
  • apps launch
  • performance tests are ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants