Add sbomnix to current Jenkins pipeline #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrirosten
reviewed
Apr 12, 2024
There was a problem hiding this comment.
Also, please consider:
- check the script format (preferably with a tool of somesort). As it now is, the indentation and formatting is a mess.
- squash any commits that don't need to be kept in the history.
- provide a short description as to what and why was changed.
|
No need to merge this to main. SBOM generation has been also tested here: |
mkaapu
requested changes
Apr 16, 2024
mnokka-unikie
force-pushed
the
add_sbomnix
branch
from
a29a482
to
bd73479
Compare
mkaapu
requested changes
Apr 19, 2024
henrirosten
reviewed
Apr 19, 2024
henrirosten
reviewed
Apr 19, 2024
ghaf-build-pipeline.groovy
Outdated
Comment on lines
89
to
91
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Please don't add any empty lines unless there's a good reason
henrirosten
reviewed
Apr 19, 2024
henrirosten
reviewed
Apr 19, 2024
mkaapu
pushed a commit
that referenced
this pull request
Apr 19, 2024
organize codes directory sturcture
Signed-off-by: mnokka-unikie <mika.nokka@unikie.com>
mnokka-unikie
force-pushed
the
add_sbomnix
branch
from
bd73479
to
5a53110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.