WIP - fix: Break the tenant reload transaction further #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JigarJoshi
force-pushed
the
jmj/break_tenant_reload_further
branch
2 times, most recently
from
5698e05
to
89cd79c
Compare
rbarabas
previously approved these changes
Jun 8, 2023
|
Breaks up search index reload process into even more granular trx. Peer reviewed during call. |
JigarJoshi
force-pushed
the
jmj/break_tenant_reload_further
branch
from
89cd79c
to
80b4eea
Compare
JigarJoshi
force-pushed
the
jmj/break_tenant_reload_further
branch
from
80b4eea
to
f2f4c45
Compare
JigarJoshi
changed the title
|
Reviewpad Report
|
|
reload() closing tx internally has caused lots of trouble in all parts of the code. |
Yes, we need to break the reload further at a more granular level |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Break the tenant reload transaction further. batch 10 search index per transaction.
How best to test these changes
Test it on dev.
Issue ticket number and link