Various test lints #457
Merged
Various test lints #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennybc
reviewed
Jan 11, 2024
tests/testthat/test-reprex.R
Outdated
| }) | ||
|
|
||
| test_that("reprex() errors for an R crash, by default", { | ||
| # TODO: consider switching to expect_snapshot() after switch to 3e | ||
| # TODO: consider switching to expect_snapshot() |
There was a problem hiding this comment.
Since this is shaping up to be ?the conclusion? of switching to testthat 3e, would you go ahead switch this to expect_snapshot()?
Likewise just below.
There was a problem hiding this comment.
I don't think the one below is worth adding as a snapshot as it spans many lines. I think it is fine as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
expect_no_error()+ other goodies from testthat 3.2.0 to make the tests a bit more clear.