Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dplyr 1.1.1 compatibility #146

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

dplyr 1.1.1 compatibility #146

wants to merge 2 commits into from

Conversation

DavisVaughan
Copy link
Member

In dplyr 1.1.1, auto_copy() now throws a different and much improved error message. multidplyr was expecting the old error message in a test and wasn't using snapshot testing. tidyverse/dplyr#6800

pf <- partition(data.frame(x = 1:6), default_cluster())
#> Initialising default cluster of size 2
df <- data.frame(x = 1:3, y = 3:1)

# Before
left_join(pf, df)
#> Error in `auto_copy()` at multidplyr/R/dplyr-dual.R:20:2:
#> ! `x` and `y` must share the same src.
#> ℹ set `copy` = TRUE (may be slow).

# After
left_join(pf, df)
#> Error in `auto_copy()` at multidplyr/R/dplyr-dual.R:20:2:
#> ! `x` and `y` must share the same source.
#> ℹ `x` is a <multidplyr_party_df> object.
#> ℹ `y` is a <data.frame> object.
#> ℹ Set `copy = TRUE` if `y` can be copied to the same source as `x` (may be slow).

DavisVaughan added a commit to tidyverse/dplyr that referenced this pull request Mar 21, 2023
@DavisVaughan
Avoid multidplyr failure, see tidyverse/multidplyr#146
8ee46e6
@DavisVaughan
Copy link
Member Author

I've added tidyverse/dplyr@8ee46e6 to revert part of the auto_copy() error message changes so that we avoid a multidplyr failure.

Probably good to still merge this though for future robustness

clrpackages pushed a commit to clearlinux-pkgs/R-dplyr that referenced this pull request Mar 23, 2023
@fenrus75
R-dplyr: Autospec creation for update from version 1.1.0 to version 1…
52c47a1 
….1.1

Davis Vaughan (36):
      Add `rename_with()` example of using `paste0(recycle0 = TRUE)` (#6690)
      Tweak advice about conditional usage of new functions (#6693)
      Require R >=3.5.0 (#6700)
      Refresh `?dplyr_extending` (#6701)
      Pass correct `user_env` through to all `filter()` warnings (#6706)
      Evaluate each group expression in a fresh data mask (#6704)
      Add tests for `arrange()` with `numeric_version` (#6699)
      Speed up `nth()` family (#6710)
      Use rlang private option when creating error context labels (#6714)
      Improve performance of `case_when()` and `case_match()` (#6711)
      Inject maskable arguments in `slice_*()` (#6726)
      Use `check_logical()` rather than `vec_assert()` in `if_else()` and `vec_case_when()` (#6715)
      Switch from `vec_is_vector()` to `obj_is_vector()` (#6729)
      Make the current group size a variable updated by reference (#6727)
      Avoid infix slowdown in `dplyr_quosures()` (#6734)
      Standardize on `arg_match0()` (#6735)
      Avoid `as_tibble()` in `group_data.tbl_df()` (#6736)
      Optimize `compute_by()` for the "no groups" case (#6737)
      Remove test related to embracing of unused missing argument (#6740)
      Use `rlang::args_data_masking` topic (#6738)
      Replace compatibility vignette with in-packages vignette (#6739)
      Add `list_flatten()` helper to avoid rlang deprecations (#6759)
      Force `pick()` empty selections to result in 1 row tibbles (#6756)
      Add named `all_of()` examples to `across()` docs (#6757)
      Implement `relationship` and refine join match warning (#6753)
      Explicitly disallow data frames with `NA` or `""` names (#6760)
      Always duplicate variables we plan to modify by reference (#6763)
      Add redirect from `dplyr_data_masking` back in (#6766)
      Use `nrow()` rather than `vec_size()` in `group_data()` (#6768)
      Use `obj_is_list()` and `obj_check_list()` (#6772)
      2023 upkeep (#6778)
      Avoid depending on the specifics of "object not found" base R errors (#6792)
      Delay `dplyr_quosures()` auto naming until needed (#6797)
      Delay label generation in error context setup (#6796)
      Improve `auto_copy()` different source error (#6800)
      Add an alias for `.data` so `?dplyr::.data` works (#6801)

DavisVaughan (26):
      Add NEWS bullet related to #6670
      Link to released site in NEWS bullet
      Add `@importFrom methods setOldClass`. Closes #6708.
      Move `.group_by_static_drop()` into `colwise-group-by.R`
      Rename `check_name()` to `check_n_name()` to avoid conflict
      Use standalone lazyeval
      Use standalone purrr
      Use standalone types-check
      Update snapshots with fixed URLs
      Update `import-standalone-types-check.R`
      Use `obj_check_vector()` and `vec_check_size()`
      Update `pick()` snapshots related to dev rlang `try_fetch()`
      Update `types-check.R` compat file to hack around check warnings
      Retrospective NEWS bullet for #6730
      Sub `Values` for `Vectors`
      Update revdep results
      Update revdep results
      Update snapshots to dev vctrs
      Require CRAN tibble and update snapshots
      Update company name
      Use CRAN rlang and vctrs
      Polish NEWS
      Update revdep results
      Update `cran-comments.md`
      dm is now fixed on CRAN
      Avoid multidplyr failure, see tidyverse/multidplyr#146

Florian Kohrt (1):
      Fix typo (#6782)

Hadley Wickham (2):
      Increment version number to 1.1.0.9000
      Increment version number to 1.1.1

Hugo Gruson (1):
      Update variable name in name injection example (#6771)

Kirill Müller (4):
      Add braces to methods (#6667)
      Add test implied by other test in `deprec-lazyeval.R` (#6741)
      Relax `summarise_at()` test (#6742)
      Generate better code in `get_slice_size()` (#6743)

Mara Averick (1):
      Add link to 1.1.0 posts to pkgdown Releases (#6684)

Michael Chirico (2):
      Optionally skip tests requiring Suggests packages (#6669)
      fix typos (#6765)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@DavisVaughan