geom_rect()
can derive corners from x
/width
or y
/height
#5862
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5861.
Briefly,
geom_rect()
can derive thexmin
/xmax
/ymin
/ymax
parameters fromx
/width
andy
/height
parameters.The trickiest thing with this PR is what is understood as 'required aesthetics'. Currently, all the parameters mentioned above are 'optional aesthetics' and the corners (
xmin
/xmax
/ymin
/ymax
) are marked as 'non missing aesthetics'. The corners are subjected to a secondcheck_required_aesthetics()
to throw a warning.A demo from the issue:
However, if there is only 1 known aesthetic per position (in the example, just the
y
aesthetic), it'll throw an error due to missing aesthetics. It might be worth considering throwing a more tailored warning in this case.Created on 2024-04-24 with reprex v2.1.0