Change density default bw = "nrd0"
to bw = "sj"
#5854
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #3825.
Briefly,
?density
recommends the"sj"
method over the"nrd0"
default. This change propagates that recommendation to ggplot2's density calculations.Some details:
calc_bw()
andprecompute_bw()
were doing the exact same task, so I merged these.var(x) == 0
, most of thestats::bw.*()
functions throw an error, so we keepbw.nrd0()
for these degenerate cases because it will not throw an error.