Skip to content

Commit

Permalink
merge pr 1164: broom v1.0.5
Browse files Browse the repository at this point in the history
  • Loading branch information
simonpcouch committed Jun 10, 2023
2 parents d7db9be + 2d05946 commit ccbc800
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 14 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
@@ -1,7 +1,7 @@
Type: Package
Package: broom
Title: Convert Statistical Objects into Tidy Tibbles
Version: 1.0.4.9000
Version: 1.0.5
Authors@R:
c(person(given = "David",
family = "Robinson",
Expand Down
2 changes: 1 addition & 1 deletion NEWS.md
@@ -1,4 +1,4 @@
# broom (development version)
# broom 1.0.5

* `tidy.coxph()` will now pass its ellipses `...` to `summary()` internally (#1151 by `@ste-tuf`).

Expand Down
2 changes: 1 addition & 1 deletion R/fixest-tidiers.R
Expand Up @@ -25,7 +25,7 @@
#' fixed effects, see \url{https://github.com/lrberge/fixest/issues/6} and
#' \url{https://github.com/sgaure/lfe/issues/1#issuecomment-530646990})
#'
#' @examplesIf rlang::is_installed("fixest")
#' @examplesIf rlang::is_installed("fixest") & !broom:::is_cran_check()
#'
#' # load libraries for models and data
#' library(fixest)
Expand Down
12 changes: 12 additions & 0 deletions R/utilities.R
Expand Up @@ -34,6 +34,8 @@ exponentiate <- function(data, col = "estimate") {
#' @return A `tibble` potentially with a `.rownames` column
#' @noRd
#'


as_augment_tibble <- function(data) {
if (inherits(data, "matrix") & is.null(colnames(data))) {
stop(
Expand Down Expand Up @@ -61,6 +63,16 @@ as_augment_tibble <- function(data) {
df
}

# adapted from ps:::is_cran_check()
is_cran_check <- function() {
if (identical(Sys.getenv("NOT_CRAN"), "true")) {
FALSE
}
else {
Sys.getenv("_R_CHECK_PACKAGE_NAME_", "") != ""
}
}

#' Convert a data.frame or matrix to a tibble
#'
#' This function is meant for use inside `tidy.*` methods.
Expand Down
9 changes: 1 addition & 8 deletions cran-comments.md
@@ -1,10 +1,3 @@
## R CMD check results

0 WARNINGS, 0 ERRORS, 0 NOTES.

# Reverse dependencies

We checked 224 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
We checked 227 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package, and saw 1 new breakage. The issue arose in the tipsae package and is expected. We [notified package maintainers of the issue](https://github.com/tidymodels/broom/issues/1160) two weeks ago and have not heard back. The breakage is an error in examples due to the deprecation of tidiers for objects from retiring spatial packages sp and rgeos.
2 changes: 1 addition & 1 deletion man/augment.fixest.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/glance.fixest.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/tidy.fixest.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ccbc800

Please sign in to comment.